Skip to content

Conversation

@mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Jul 4, 2020

This suppresses writev warnings on EPIPE. But mainly it addresses, and therefore hopefully fix #2268 and fix #2293. @karenetheridge Do you agree?

EDIT: remove the writev stuff in favour of #2346

@karenetheridge
Copy link
Contributor

Am I inferring correctly that this PR changes the people in the mailto: link to everyone who has comaint, not just the first-come holder?

@mohawk2
Copy link
Contributor Author

mohawk2 commented Jul 4, 2020

@karenetheridge Yes, that's what I was trying to achieve?

@mohawk2 mohawk2 force-pushed the mohawk2/logtidy branch from 66abf70 to 7ecaeb0 Compare July 4, 2020 11:51
@mohawk2 mohawk2 changed the title Expand the "notification" addressee list for ADOPTME etc, suppress writev warnings Expand the "notification" addressee list for ADOPTME etc Jul 4, 2020
@mohawk2 mohawk2 force-pushed the mohawk2/logtidy branch from 7ecaeb0 to 077e096 Compare July 4, 2020 12:01
@mohawk2 mohawk2 requested a review from haarg July 4, 2020 18:04
@mohawk2
Copy link
Contributor Author

mohawk2 commented Jul 5, 2020

t/model/permission.t now provides a pattern for how to mock the API. This could probably be generalised a bit more.

@mohawk2 mohawk2 merged commit 9be16b5 into master Jul 6, 2020
@mohawk2 mohawk2 deleted the mohawk2/logtidy branch July 6, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants