exclude t and xt directory from other files at search time #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We filter out any files in t or xt when separating out where to list them on the release page. If these files aren't filtered out in our intial query, it can inflate the number of results over our 250 limit, so that files we actually want to display won't be included. This was the case for https://metacpan.org/release/OCBNET/CSS-Sass-3.3.4. It has thousands of files in t/ named expected_output.css. As a result, most of the files we care about in the root weren't shown.
Member
| Why did the push check fail while the PR check passed? |
Member
| 👍 |
Member Author
| I accidentally included an unrelated commit, then force pushed it away. Travis tried to check that first push, but the commits weren't available by the time it started its run. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We filter out any files in t or xt when separating out where to list
them on the release page. If these files aren't filtered out in our
intial query, it can inflate the number of results over our 250 limit,
so that files we actually want to display won't be included.
This was the case for https://metacpan.org/release/OCBNET/CSS-Sass-3.3.4.
It has thousands of files in t/ named expected_output.css. As a result,
most of the files we care about in the root weren't shown.