Skip to content

Conversation

@bessarabov
Copy link
Contributor

This is just an experiment. It works, but it should be well tested.

If you will accept this PR, the next good step is to create automatic build images — https://docs.docker.com/docker-hub/builds/

The task I'm trying to acieve is to create my own darkpan instance and dockerizing metacpan-web makes this task much simpler.

@oalders
Copy link
Member

oalders commented Nov 2, 2014

Sounds good to me. Anyone else have thoughts?

@ranguard
Copy link
Member

ranguard commented Nov 2, 2014

Nice thing to have, but unless we are officially supporting it (and I think we have enough to do already) then I don't think it should be in this repo.

We could have a separate docker repo though, with a readme explaining it is experimental?

On 2 Nov 2014, at 02:27, Olaf Alders notifications@github.com wrote:

Sounds good to me. Anyone else have thoughts?


Reply to this email directly or view it on GitHub.

@bessarabov
Copy link
Contributor Author

Nice thing to have, but unless we are officially supporting it (and I think we have enough to do already) then I don't think it should be in this repo.

I agree that this change should not make your life harder.

We could have a separate docker repo though, with a readme explaining it is experimental?

I did the sample repo: https://github.com/bessarabov/metacpan-web-docker

But I think that the best place for Dockerfile is in the official repo. Even that this feature is highly experimental, to make things simpler it is better to place Dockerfile here. I've updated this PR and added some text to README.md that explains this.

@oalders
Copy link
Member

oalders commented Nov 2, 2014

That's helpful. Is it also possible to add an "experimental, see README" comment to the Dockerfile itself?

@bessarabov
Copy link
Contributor Author

That's helpful. Is it also possible to add an "experimental, see README" comment to the Dockerfile itself?

Good point. Done in 9b68fd1

@ranguard
Copy link
Member

ranguard commented Nov 2, 2014

I'd prefer for us (so in CPAN-API) to have a metacpan-docker repo, with web, elasticsearch, api directories in there and the Docker files in each. This would sort of match the metacpan-puppet, which is ultimately about deployment of the various components.

Happy to set this up if there is interest?

@ranguard
Copy link
Member

ranguard commented Nov 3, 2014

Hi @bessarabov,

I've just invited you to: https://github.com/CPAN-API/metacpan-docker (you have write access there).

Please create a metacpan-web/Dockerfile in there, later we could have cpan-api/Dockerfile and maybe even a elasticsearch/Dockerfile if you want to go that far.

Once you've got things going we can then link to the docker repo from other places to let people know it exists.

A side note, if things start getting complicated for the Docker instances (and more importantly if they are likely to get out of step with our puppet configurations) we could easily look at adding some stuff to metacpan-puppet to be part of the docker setup.

Closing this pull for now as further discussions can be in the metacpan-docker repo

@ranguard ranguard closed this Nov 3, 2014
@bessarabov
Copy link
Contributor Author

@ranguard Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants