Fix shape error in qNegIntegratedPosteriorVariance #3068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Summary: `qNegIntegratedPosteriorVariance` doesn't work through MBM due to a shape bug. This diff addresses the underlying issue and would allow us to use active learning through Ax (at some point). Differential Revision: D85507279
meta-cla bot added the CLA Signed 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #3068 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 217 217 Lines 20732 20732 ========================================= Hits 20732 20732 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| This pull request has been merged in 15a87e1. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary:
qNegIntegratedPosteriorVariancedoesn't work through MBM due to a shape bug. This diff addresses the underlying issue and would allow us to use active learning through Ax (at some point).Differential Revision: D85507279