Added MV video link generation capability #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oboratav commented Sep 21, 2018
| result = __returnhandler(dashboard.status_code, dashboard.text, calltype, suppressprint) | ||
| return result | ||
| | ||
| def get_video_link(apikey, serial, timestamp=None, suppressprint=False): |
Author
There was a problem hiding this comment.
The function was named according to PEP-8, which prefers words separated by underscores. It does look a bit different when compared to the other functions throughout the rest of the module, however I think this is far easier to read. Should we keep it as it is, or change it to something like getvideolink() to match the rest of the module?
cemersoz approved these changes Oct 1, 2018
cemersoz left a comment
cemersoz left a comment There was a problem hiding this comment.
Extends functionality in a meaningful way and fits all style standards as far as I can tell. I'd love this functionality in the official repo!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added the ability to use the new MV endpoint that was revealed about a week ago by GeorgeB on the community forums (link below)
https://community.meraki.com/t5/Solutions-APIs/New-MV-API-Returns-video-link-for-the-specified-camera/m-p/27916#M624