- Notifications
You must be signed in to change notification settings - Fork 179
[master < T507-FL] EmptyResult operator #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review as asked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some commented code + some form of testing is missing.
I would add a new test here -> https://github.com/memgraph/memgraph/tree/master/tests/gql_behave/tests/memgraph_V1, but probably there are other viable options 😄
I changed all unit tests that make use of this new operator, doesn't this suffice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator looks good, but on the planner side I am not sure if the logic is correct.
In general, unit tests are great, but the e2e test helps you to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The e2e test I've mentioned has been added so I'll approve this PR
[master < Epic] PR
[master < Task] PR
Closes #650