Skip to content

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Nov 25, 2022

[master < Epic] PR

  • Check, and update documentation if necessary
  • Update changelog
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Update changelog
  • Provide the full content or a guide for the final git message

Closes #650

@jbajic jbajic changed the title [master < ] EmptyResult operator [master < T507-FL] EmptyResult operator Dec 2, 2022
Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review as asked

@as51340 as51340 requested a review from kostasrim December 5, 2022 07:39
@as51340 as51340 marked this pull request as ready for review December 5, 2022 15:53
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some commented code + some form of testing is missing.

I would add a new test here -> https://github.com/memgraph/memgraph/tree/master/tests/gql_behave/tests/memgraph_V1, but probably there are other viable options 😄

@as51340
Copy link
Contributor Author

as51340 commented Dec 6, 2022

There is some commented code + some form of testing is missing.

I would add a new test here -> https://github.com/memgraph/memgraph/tree/master/tests/gql_behave/tests/memgraph_V1, but probably there are other viable options smile

I changed all unit tests that make use of this new operator, doesn't this suffice?

Copy link
Contributor

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator looks good, but on the planner side I am not sure if the logic is correct.

@gitbuda
Copy link
Member

gitbuda commented Dec 6, 2022

There is some commented code + some form of testing is missing.
I would add a new test here -> https://github.com/memgraph/memgraph/tree/master/tests/gql_behave/tests/memgraph_V1, but probably there are other viable options smile

I changed all unit tests that make use of this new operator, doesn't this suffice?

In general, unit tests are great, but the e2e test helps you to:

  • get real confidence the feature is really working
  • spot some weird bugs which are not detectable by simply thinking about a small unit of testing
    That being said, if nothing else, I would add at least one e2e test query, if nothing else for the sale of sanity check 😄
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e test I've mentioned has been added so I'll approve this PR

@as51340 as51340 requested a review from jbajic December 7, 2022 23:22
@gitbuda gitbuda merged commit 0f77c85 into master Dec 9, 2022
@gitbuda gitbuda deleted the T507-FL-EmptyResult-Operator branch December 9, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants