Skip to content

Bugfix: Parallel snapshot fails if sendfile can't send the whole file at once #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Bugfix: Parallel snapshot fails if sendfile can't send the whole file at once #2995

merged 1 commit into from
May 30, 2025

Conversation

@andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented May 27, 2025

No description provided.

@andrejtonev andrejtonev self-assigned this May 27, 2025
@andrejtonev
Copy link
Contributor Author

andrejtonev commented May 27, 2025 •
edited
Loading

Git commit description, explain the changes you made here

Leave above in PR description, copy the below into a comment

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Made parallel snapshot more flexible while combining temporary file into a single snapshot. Users are now less restricted on the batch size they can use. Experiment with larger batch sizes. 2995
  • Better parallel snapshot docs documentation#1301
    • Is back linked to this development PR
  • @katarinasupe @gitbuda
@andrejtonev andrejtonev force-pushed the parallel_snapshot_fix branch from a6b0c68 to 1343246 Compare May 30, 2025 11:18
@andrejtonev andrejtonev requested a review from as51340 May 30, 2025 11:18
@andrejtonev andrejtonev added bug bug Docs needed Docs needed CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push labels May 30, 2025
@andrejtonev andrejtonev added this to the mg-v3.3.0 milestone May 30, 2025
@andrejtonev andrejtonev changed the title Bugfix: Parallel snapshot forces small temp files Bugfix: Parallel snapshot fails if sendfile can't send the whole file at once May 30, 2025
@andrejtonev andrejtonev linked an issue May 30, 2025 that may be closed by this pull request
Parallel snapshot fails with "Couldn't copy edge part to snapshot!" #3006
Closed
@andrejtonev andrejtonev force-pushed the parallel_snapshot_fix branch 2 times, most recently from df0a789 to 14542b5 Compare May 30, 2025 12:41
@andrejtonev andrejtonev force-pushed the parallel_snapshot_fix branch from 14542b5 to 3c1624f Compare May 30, 2025 12:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@andrejtonev andrejtonev added this pull request to the merge queue May 30, 2025
Merged via the queue into master with commit 1d54a15 May 30, 2025
17 checks passed
@andrejtonev andrejtonev deleted the parallel_snapshot_fix branch May 30, 2025 17:33
@andrejtonev andrejtonev mentioned this pull request Jun 2, 2025
Merged
11 tasks
@gitbuda gitbuda mentioned this pull request Jun 3, 2025
Merged
16 tasks
as51340 pushed a commit that referenced this pull request Oct 24, 2025
@andrejtonev
Bugfix: Parallel snapshot fails if sendfile can't send the whole file…
c2ee461 
… at once (#2995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed

3 participants

@andrejtonev @Ignition