[master < E098-MG] Introduce Pulsar stream source #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
antonio2368 requested review from antaljanosbenjamin, gitbuda, jbajic and kostasrim 
antonio2368 force-pushed the E098-MG-introduce-new-stream-source branch from 416ddc7 to e8976e0 Compare 
antonio2368 commented Nov 16, 2021
antonio2368 force-pushed the E098-MG-introduce-new-stream-source branch from 093ffe0 to 2df12c0 Compare 
antaljanosbenjamin approved these changes Nov 16, 2021
There was a problem hiding this comment.
I will approve it to be not a bottleneck, but please check my comments. I think the only important fix is prefixing LZ4_NbCommonBytes (I wasn't able to verify whether the kafka and pulsar implementation does the same or not), but the other comments is not that important, as the constant is the same for both libs.
antonio2368 force-pushed the E098-MG-introduce-new-stream-source branch from 2df12c0 to 12f4e00 Compare 
jbajic reviewed Nov 16, 2021
kostasrim approved these changes Nov 16, 2021
| Awesome work 🚀 |
jbajic approved these changes Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
[master < Epic] PR