Skip to content

Periodic commit transaction logic #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 138 commits into from
Aug 8, 2024
Merged

Periodic commit transaction logic #2217

merged 138 commits into from
Aug 8, 2024

Conversation

Josipmrden
Copy link
Contributor

Periodic commit transaction logic.
Josipmrden added 30 commits July 5, 2024 12:25
@Josipmrden
Add periodic commit syntax
cdfbc4f
@Josipmrden
Make build pass
a7715ce
@Josipmrden
Remove commit frequency from cypherquery
f303bb4
@Josipmrden
Adjust if else statements in the cypher visitor
ad0ace2
@Josipmrden
Add tests
57475f4
@Josipmrden
Disable periodic commit to run
b5eb6c3
@Josipmrden
Add nested periodic commit parsing
28da16d
@Josipmrden
Merge branch 'master' into periodic-commit-syntax
635ebb0
@Josipmrden
Disable periodic commit for nested queries
bae4f6e
@Josipmrden
Aesthetic changes
62167db
@Josipmrden
Clang tidy
e0899ea
@Josipmrden
Make planner create periodic commit operator
fb7fd48
@Josipmrden
Fix test
0beac6b
@Josipmrden
Managing to provide only one periodic commit
1356a7f
@Josipmrden
Add create query plans
de919c3
@Josipmrden
Add call procedure plans
67dfbe5
@Josipmrden
Added plans for whole query periodic commits
a325e33
@Josipmrden
Add create plans with produce
cbd5606
@Josipmrden
Merge branch 'master' into periodic-commit-syntax
89895d8
@Josipmrden
Merge branch 'periodic-commit-syntax' into periodic-commit-query-plan…
9fc1de0 
…ning
@Josipmrden
Disable delete and periodic commit in same query
b6aa76f
@Josipmrden
Add tests for delete
4cdda62
@Josipmrden
Clang tidy
0752853
@Josipmrden
Clang tidy
67ffcd2
@Josipmrden
Merge branch 'periodic-commit-syntax' into periodic-commit-query-plan…
22e0123 
…ning
@Josipmrden
PeriodicCommit operator implementation
27942c3
@Josipmrden
Clang tidy
9f0de46
@Josipmrden
Return delete test
551746c
@Josipmrden
Remove delete restrictions
3e1e75b
@Josipmrden
Configure query plan for with inside subquery
334c13a
@gitbuda gitbuda mentioned this pull request Aug 7, 2024
Open
andrejtonev
andrejtonev approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck :D
@Josipmrden Josipmrden removed CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels Aug 7, 2024
@Josipmrden Josipmrden enabled auto-merge August 7, 2024 21:45
@Josipmrden Josipmrden disabled auto-merge August 7, 2024 21:45
@Josipmrden Josipmrden added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2024
@Ignition Ignition added this pull request to the merge queue Aug 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.4% Duplication on New Code

See analysis details on SonarCloud
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2024
@Josipmrden Josipmrden added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit 1535a2a Aug 8, 2024
@Josipmrden Josipmrden deleted the periodic-commit-release branch August 8, 2024 07:06
@kgolubic
Copy link
Contributor

For release notes I'll use:

  • Added periodic commit transaction logic.
    #2217
@Josipmrden Josipmrden mentioned this pull request Nov 21, 2024
Closed
@Ignition Ignition mentioned this pull request Feb 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2025
@Ignition
Planner and LabelPropertyIndex improvements (#2722)
0b9bbbb 
Added `--debug-query-plans`, this will DEBUG log all potential plans along with their estimated cost. This is useful for working out problems with plan generation or with the cost estimator. Improved Filter's cost. Pattern filters are now considered as separate branches which need accumulating before contributing to the cost of the filter. Performance bugfix for `CanSeeEntityWithTimestamp`, Periodic commit changes #2217 made a slight logic bug which made skipping over irrelevant index entries more expensive than they needed to be. Modified cost estimator to acknowledge that nothing is completely cost free, even if the cardinality is 0 there is still a minimal amount of work involved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer customer Docs needed Docs needed feature feature

4 participants

@Josipmrden @kgolubic @Ignition @andrejtonev