- Notifications
You must be signed in to change notification settings - Fork 179
Add force sync REPLICA with MAIN #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f807508
to c70fe72
Compare 4a6fb3f
to 647dc61
Compare General question about the scheme; why do we care about epochs? Shouldn't everyone have the same history? If the epoch do not align, then we have a branching point and the two instances cannot continue as part of the same cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. A few comments.
I will leave this one to Andreja to handle it, high-level looks good to me |
bd5b443
to 6746172
Compare
We synced about this. So the issue was that the Notion page was out of sync. I don't deal with epochs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@kgolubic tagging you here: |
Docs here: |
This PR enables the cluster to continue executing if the MAIN is behind REPLICA. It can happen in the scenario as in the test case, or when one of the tenants on other REPLICA is behind MAIN's tenant. In both cases, the result is the same -> force sync of tenant with MAIN's tenant.
This is as agreed in user story for 2.15/2.16 -> Link here
[master < Task] PR
To keep docs changelog up to date, one more thing to do: