- Notifications
You must be signed in to change notification settings - Fork 179
[master < T1140] Add ToString for mgp::Value and all mgp types #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vpavicic will write documentation when PR is reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. The suggestion to use string::append because the ToString
methods build a std::string
applies to all methods here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Left a few comments related to formatting and testing.
622c9e4
to b4cfbe7
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go here 🚀
Left a small suggestion, but the PR is approvable either way.
0aee0ca
to c9096c3
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG
[master < Task] PR
For util.md5 function in c++ util query module, a need for ToString method arised, so it was implemented.
To keep docs changelog up to date, one more thing to do:
Users can now call ToString() method on mgp::Value and Memgraph's data types when writing C++ query modules.