Skip to content

Conversation

@Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Apr 3, 2024

Description

Periodic and do modules were refactored to work with the Memgraph API without the need to authenticate the client.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

Doesn't resolve but related to this

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Periodic and do modules now work with the Memgraph API without the need for a user to authenticate
  • Link the documentation PR here
  • Tag someone from docs team in the comments @kgolubic
@Josipmrden Josipmrden added Docs needed Docs needed bug bug labels Apr 3, 2024
@Josipmrden Josipmrden added this to the 1.16.0 milestone Apr 3, 2024
@Josipmrden Josipmrden self-assigned this Apr 3, 2024
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Left two quick comments before I may approve.

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and approve from me

@Josipmrden Josipmrden merged commit 2e0c415 into main Apr 7, 2024
@Josipmrden Josipmrden deleted the test-query-execution-in-mage branch April 7, 2024 13:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug Docs needed Docs needed

4 participants