Skip to content

Conversation

@melihaksoy
Copy link
Owner

@melihaksoy melihaksoy commented Sep 13, 2019

Introduces improvements both for code style & styles.xml.
Closes #35
Closes #8

@melihaksoy melihaksoy self-assigned this Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #36 into master will increase coverage by 1.67%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #36 +/- ## ========================================== + Coverage 24.44% 26.11% +1.67%  ========================================== Files 48 16 -32 Lines 405 134 -271 Branches 51 11 -40 ========================================== - Hits 99 35 -64  + Misses 286 91 -195  + Partials 20 8 -12
Impacted Files Coverage Δ
...lin/com/melih/core/base/viewmodel/BaseViewModel.kt 25% <ø> (ø) ⬆️
...com/melih/core/base/paging/BasePagingDataSource.kt 87.09% <ø> (ø) ⬆️
...n/com/melih/core/extensions/LifecycleExtensions.kt 0% <ø> (ø) ⬆️
.../melih/core/base/recycler/BasePagingListAdapter.kt 0% <ø> (ø) ⬆️
...tlin/com/melih/core/base/lifecycle/BaseFragment.kt 0% <ø> (ø) ⬆️
...om/melih/core/base/lifecycle/BaseDaggerFragment.kt 0% <ø> (ø) ⬆️
...in/com/melih/core/base/paging/BasePagingFactory.kt 80% <ø> (ø) ⬆️
...m/melih/core/base/viewmodel/BasePagingViewModel.kt 0% <0%> (ø) ⬆️
...in/com/melih/core/extensions/RecyclerExtensions.kt 0% <0%> (ø) ⬆️
...ository/persistence/converters/MissionConverter.kt
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a10edc...aaaeb2a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #36 into master will increase coverage by 1.67%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #36 +/- ## ========================================== + Coverage 24.44% 26.11% +1.67%  ========================================== Files 48 16 -32 Lines 405 134 -271 Branches 51 11 -40 ========================================== - Hits 99 35 -64  + Misses 286 91 -195  + Partials 20 8 -12
Impacted Files Coverage Δ
...lin/com/melih/core/base/viewmodel/BaseViewModel.kt 25% <ø> (ø) ⬆️
...com/melih/core/base/paging/BasePagingDataSource.kt 87.09% <ø> (ø) ⬆️
...n/com/melih/core/extensions/LifecycleExtensions.kt 0% <ø> (ø) ⬆️
.../melih/core/base/recycler/BasePagingListAdapter.kt 0% <ø> (ø) ⬆️
...tlin/com/melih/core/base/lifecycle/BaseFragment.kt 0% <ø> (ø) ⬆️
...om/melih/core/base/lifecycle/BaseDaggerFragment.kt 0% <ø> (ø) ⬆️
...in/com/melih/core/base/paging/BasePagingFactory.kt 80% <ø> (ø) ⬆️
...m/melih/core/base/viewmodel/BasePagingViewModel.kt 0% <0%> (ø) ⬆️
...in/com/melih/core/extensions/RecyclerExtensions.kt 0% <0%> (ø) ⬆️
...ository/persistence/converters/MissionConverter.kt
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a10edc...aaaeb2a. Read the comment docs.

@melihaksoy melihaksoy merged commit 99a2abf into master Sep 13, 2019
@melihaksoy melihaksoy deleted the feature/styling branch September 13, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants