#77 Close fullscreen using the control fix #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I have 2.0.0 but the fullscreen button still only enters fullscreen. Going out doesn't work. |
| @Bram-Zijp I hadn't deployed it as I was going to bundle in a another fix before deploying. I just released v2.0.1. It's being published as we speak. Let me know if it works. https://travis-ci.org/mderrick/react-html5video/builds/209022178 |
| Works like a charm, thanks. Side note; I had to add these styles to get the default player playbar svg icons to display correctly (they were to small). |
| I wouldn't rely on those classnames as they change per build. For now, I'd add a custom className to the Could you please create an issue with the the exact browser version and I will look on fixing it. Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Inspired by #78 fixing bug #77 but with added tests.