Skip to content

Conversation

@rdjpalmer
Copy link
Contributor

Add style prop support to the container div, allowing users of JavaScript based styles to target the container div in the same manor as when using the className prop

@mderrick
Copy link
Owner

mderrick commented Oct 13, 2016

Do you envisage users ever needing to add styles to the HTML5 video itself too? As this obviously removes that functionality. Otherwise this change looks way more useful.

@rdjpalmer
Copy link
Contributor Author

There's certainly a case for applying the styles to the video element. However, the inconsistency between how the className and style props are being applied is a bigger issue in my opinion. I'm thinking it should be something like:

<div className={this.getVideoClassName()} style={this.props.style}> <video /> </div> // OR <div> <video className={this.getVideoClassName()} style={this.props.style} /> </div>

rather than:

// Current, inconsistent styling <div className={this.getVideoClassName()}> <video style={this.props.style /> </div>

My preference is for the former as it's a smaller change and has less impact on those already using those classes

@rdjpalmer
Copy link
Contributor Author

Hey @mderrick, do you have any status update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants