MAX EIRP is 13dBm (= 19.95mW < 20mW) in as923jp #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
terrillmoore requested changes Feb 22, 2021
Member
terrillmoore left a comment
terrillmoore left a comment There was a problem hiding this comment.
Thanks again. Happy to accept with changes along the line I suggest.
| //#define CFG_au915 1 | ||
| //#define CFG_as923 1 | ||
| // #define LMIC_COUNTRY_CODE LMIC_COUNTRY_CODE_JP /* for as923-JP */ | ||
| //#define CFG_as923jp 1 |
Member
There was a problem hiding this comment.
Thanks for your contribution.
I don't understand this part of change. The code on line 6 is the correct way to handle this (and in fact lmic_confgi_preconditions.h expands the shorthand). We avoid #ifdef as much as possible in the code; the config system converts #ifdef to equivalent symbols that are always either 1 or 0.
| AS923_FREQ_MAX = 928000000 | ||
| }; | ||
| enum { | ||
| #if defined(CFG_as923jp) |
Member
There was a problem hiding this comment.
Similarly, this line should be #if LMIC_COUNTRY_CODE == LMIC_COUNTRY_CODE_JP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
16dBm is used as MAX EIRP when using OTAA in as923. However MAX EIRP is 13dBm in as923jp.