v3.1.0 - sx1272 - line misspelled #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I found this misspelled on the code when I tried to use sx1272 lora module.
terrillmoore requested changes Feb 14, 2020
Member
terrillmoore left a comment
terrillmoore left a comment There was a problem hiding this comment.
See comments. Thanks very much for submitting this PR!
src/lmic/radio.c Outdated
| // set ModemConfig2 (sf, AgcAutoOn=1 SymbTimeoutHi) | ||
| u1_t mc2; | ||
| mc2 = (SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3)); | ||
| mc2 = ((SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3)); |
Member
There was a problem hiding this comment.
Huh. I wonder how this got through CI testing, as I thought I was compiling for SX1272.
This will work, but I think it's more matching the rest of the style to remove the extra ) at the end of the line, i.e.:
mc2 = (SX1272_MC2_SF7 + ((sf-1)<<4)) | 0x04 | ((LMIC.rxsyms >> 8) & 0x3);The intent is to compute a | b | c; the extra parens make it harder to read.
Author
There was a problem hiding this comment.
I don't know why I put an extra ( instead of deleting the ) 😄
Remove extra `(` and `)`
terrillmoore added a commit that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I found this misspelled on the code when I tried to use sx1272 lora module.
arduino-lmic/src/lmic/radio.c
Line 537 in f67121c