M2354: Fix compile error with TF-M integration #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ccli8 force-pushed the nvt_m2354_fix_tfm_compile branch from 10300d0 to f7fdd98 Compare ...ets/TARGET_NUVOTON/TARGET_M2354/TARGET_TFM/TARGET_NU_M2354/COMPONENT_TFM_S_FW/CMakeLists.txt Outdated Show resolved Hide resolved
Collaborator
multiplemonomials left a comment
multiplemonomials left a comment There was a problem hiding this comment.
Looks good just one random fix I noticed to the python.
Also p.s. a lot of this logic would be cleaner if you used pathlib from python3, but that can be a problem for later.
In CMake, mbed-psa moves out of mbed-core, its library type changing to STATIC from INTERFACE. Following this modification, the platform TF-M code relying on mbed-psa needs to explicitly specify the dependency through target_link_libraries().
Update post-build script to enable OUTPUT_EXT can be set to "bin" or "hex" in targets.json5.
shutil.which("python3") can locate incorrect path when there are multiple python3 installations. Instead, follow the link below, use sys.executable. https://docs.python.org/3/library/sys.html#sys.executable ccli8 force-pushed the nvt_m2354_fix_tfm_compile branch from f7fdd98 to 26f754c Compare 
multiplemonomials approved these changes Aug 23, 2024
Collaborator
| Thanks so much for testing this out! By the way, if you'd like to submit some upload method files (under mbed-os/targets/upload_method_cfg) for Nuvoton boards, I'd be very grateful! Plus it would help people use your boards more easily |
Author
It is our on-going plan. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
This fixes compile errors with TF-M integration on
NU_M2354target, including:mbed-psamoves out ofmbed-core, its library type changeng to STATIC from INTERFACE. Following this modification, the platform TF-M code relying onmbed-psaneeds to explicitly specify the dependency throughtarget_link_libraries().OUTPUT_EXTcan be set to "bin" or "hex" in targets.json5.Pull request type