Skip to content

Conversation

@mmoll
Copy link
Contributor

@mmoll mmoll commented Apr 18, 2019

Type of PR

  • Bugfix
  • New Feature
  • Other (explain):

Breaking changes

  • Yes, this is a breaking change

I'm unsure if this is breaking (major bump) or only a new feature (minor bump).

Description

This ensures that something like if (! $lala) { is autofixed to if (!$lala) {.

@mmoll
Copy link
Contributor Author

mmoll commented Apr 18, 2019

Maybe this should later/also be part of the Symfony CS? https://symfony.com/doc/current/contributing/code/standards.html says "Place unary operators (!, --, ...) adjacent to the affected variable;"

1 similar comment
@mmoll
Copy link
Contributor Author

mmoll commented Apr 18, 2019

Maybe this should later/also be part of the Symfony CS? https://symfony.com/doc/current/contributing/code/standards.html says "Place unary operators (!, --, ...) adjacent to the affected variable;"

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #125 +/- ## ======================================= Coverage 100% 100% Complexity 133 133 ======================================= Files 6 6 Lines 556 556 ======================================= Hits 556 556

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be626b3...6935d83. Read the comment docs.

@Ma27
Copy link
Contributor

Ma27 commented Apr 18, 2019

Do we want to file an issue at the Symfony CS then? If they don't want to implement this, we can merge this after that :)

@mmoll
Copy link
Contributor Author

mmoll commented Apr 21, 2019

This is mainly to pull in Generic.Formatting.SpaceAfterNot
@mmoll mmoll changed the title add Generic.Formatting.SpaceAfterNot Update required symfony2-coding-standard version Apr 23, 2019
@mmoll
Copy link
Contributor Author

mmoll commented Apr 23, 2019

@Ma27 please re-review ☝️

@mmoll mmoll merged commit 11f02e3 into mayflower:master Apr 23, 2019
@mmoll mmoll deleted the SpaceAfterNot branch April 23, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants