Skip to content

Conversation

@Hywan
Copy link
Member

@Hywan Hywan commented Nov 7, 2025

🚧 WIP 🚧

This patch replaces deadpool-sqlite by our own implementation in crate::connection. It still uses deadpool but the object manager has a different implementation.

Hywan added 2 commits November 7, 2025 15:56
This patch replaces `deadpool-sqlite` by our own implementation in `crate::connection`. It still uses `deadpool` but the object manager has a different implementation.
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.61%. Comparing base (3b14184) to head (c3491bf).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-sqlite/src/connection.rs 90.00% 3 Missing ⚠️
crates/matrix-sdk-sqlite/src/crypto_store.rs 50.00% 0 Missing and 1 partial ⚠️
crates/matrix-sdk-sqlite/src/state_store.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #5841 +/- ## ========================================== - Coverage 88.61% 88.61% -0.01%  ========================================== Files 361 362 +1 Lines 102269 102297 +28 Branches 102269 102297 +28 ========================================== + Hits 90627 90646 +19  - Misses 7420 7427 +7  - Partials 4222 4224 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #5841 will not alter performance

Comparing Hywan:feat-sqlite-custom-pool-manager (c3491bf) with main (3b14184)

Summary

✅ 50 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant