crypto: store received room key bundle data information #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch 3 times, most recently from 00a01ec to cd6d8af Compare 
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #4932 +/- ## ========================================== - Coverage 85.98% 85.91% -0.07% ========================================== Files 325 325 Lines 35654 35690 +36 ========================================== + Hits 30657 30663 +6 - Misses 4997 5027 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 7fa98b0 to 8131301 Compare 
poljar approved these changes Apr 23, 2025
Contributor
poljar left a comment
poljar left a comment There was a problem hiding this comment.
Looks good. I left a couple of nits.
crates/matrix-sdk-sqlite/migrations/crypto_store/010_received_room_key_bundles.sql Outdated Show resolved Hide resolved
richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 974a60e to 131022b Compare After we receive a to-device message holding room key bundle info, add the data to the store's Changes structure
richvdh force-pushed the rav/history_sharing/save_key_bundle_data branch from 131022b to 85e0626 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add hooks to the memory store and sqlite store to stash the information about room key data.
Fixes #4512