This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix crash on joining rooms #6841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
#6818 passed roomType in obbData & then used oobData without null checking, but we don't always have oobData so joining a room from /join or from an invite would crash. Type: defect
github-actions bot added the T-Defect 
| Duplicate of #6830 ? |
germain-gg approved these changes Sep 20, 2021
| Ah, I missed the other fix - merged that instead |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#6818 passed roomType
in obbData & then used oobData without null checking, but we don't always
have oobData so joining a room from /join or from an invite would crash.
Fixes element-hq/element-web#19085
Type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://6148745ff5df65a5aee3d1c1--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.