Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 25, 2021

Fixes element-hq/element-web#18533
There will be a smaller diff once #6677 gets merged

Blocked by @janogarcia , currently awaiting confirmation of how the UI should be, this pull request creates an arbitrary breakpoints and a simple UI. The look is still being decided, and only minor changes should follow.

Screen Shot 2021-08-25 at 18 02 28

Screen Shot 2021-08-25 at 18 02 34


Here's what your changelog entry will look like:

✨ Features

Preview: https://6135c4b7988a0277d8747064--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Germain Souquet added 5 commits August 25, 2021 11:35
Preparation work for narrow layout of the message composer. The voice record button needed to be extracted from VoiceRecordComposerTile
@germain-gg germain-gg added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 25, 2021
@germain-gg germain-gg requested review from a team and janogarcia August 25, 2021 17:03
@turt2live turt2live self-requested a review August 25, 2021 17:14
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good - thanks :D

@germain-gg germain-gg requested a review from turt2live August 31, 2021 07:48
@germain-gg
Copy link
Contributor Author

@turt2live am I right to assume that your previous comment should be approve?

@germain-gg germain-gg requested a review from turt2live September 3, 2021 11:04
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good :D just a small amount of code cleanup

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Apologies for the round trips :s

@germain-gg germain-gg merged commit 59de3c9 into develop Sep 7, 2021
@germain-gg germain-gg deleted the gsouquet/compact-composer-18533 branch September 7, 2021 04:07
@turt2live
Copy link
Member

this was still pending design review, so reverting as that probably wasn't the intention to land right away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

2 participants