This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Focus composer after reacting #6332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…er-reaction/11023
Member
| Hmm won't these focus the wrong composer if used whilst editing a message? |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Contributor Author
This is the current behaviour but we should change it |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
t3chguy reviewed Jul 8, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
t3chguy approved these changes Jul 9, 2021
| // paste end up in the newly focused element, | ||
| // so dispatch synchronously before paste happens | ||
| dis.fire(Action.FocusComposer, true); | ||
| dis.fire(Action.FocusSendMessageComposer, true); |
Member
There was a problem hiding this comment.
this one I'm not sure about, but happy to go with it for the time being
| if (!isClickShortcut && ev.key !== Key.TAB && !canElementReceiveInput(ev.target)) { | ||
| // synchronous dispatch so we focus before key generates input | ||
| dis.fire(Action.FocusComposer, true); | ||
| dis.fire(Action.FocusSendMessageComposer, true); |
Member
There was a problem hiding this comment.
this one I'm not sure about, but happy to go with it for the time being
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11023