Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@germain-gg
Copy link
Contributor

Partially addresses element-hq/element-web#17730

Screen Shot 2021-06-25 at 15 55 18

@germain-gg germain-gg requested a review from a team June 28, 2021 07:54
@t3chguy t3chguy requested a review from a team June 28, 2021 07:54
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM

@germain-gg
Copy link
Contributor Author

This was already discussed and reviewed by @gaelledel therefore removing the design review here

@germain-gg germain-gg removed the request for review from a team June 28, 2021 08:02
@t3chguy
Copy link
Member

t3chguy commented Jun 28, 2021

It is always good to make use of the checkmarks in github to leave a paper trail as to which designer did what if it needs more input later, this of course is a tiny changeset but best not make specialcases

@germain-gg germain-gg merged commit a576362 into develop Jun 28, 2021
@germain-gg germain-gg deleted the gsouquet/toast-button-kind branch June 28, 2021 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants