This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Update membership reason handling, including leave reason displaying #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Incorporates ideas from #6198
Contributor
| @turt2live is it trivial to apply a distinct style to the reason text? |
Member Author
| far from trivial, unfortunately. |
Contributor
| Ok, that's a shame. So the current implementation is a little clunky and inelegant. Relatedly, there's also a bunch of unnecessary periods/punctuation on these messages. A couple of requests:
|
Member Author
| @nadonomy screenshot/build updated - let me know if I've misinterpreted that somehow 😅 |
Member
| @turt2live #6257 paves a path to making it possible for TextToEvent to be able to enrich its output with JSX |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Incorporates ideas from #6198
Proof that MELS is fine:
