Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add call silencing #6082

Merged
merged 7 commits into from
Jun 17, 2021
Merged

Add call silencing #6082

merged 7 commits into from
Jun 17, 2021

Conversation

@SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented May 22, 2021 •
edited
Loading

According to this design

Screenshot_20210522_202720

Screenshot_20210522_202732
@SimonBrandner
Add icons for silencing
cbc31b4 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Export AudioIDs
21fb81d 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add styling for silencing
c678211 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add silencing
b08b36c 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
i18n
8b7a73b 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@turt2live turt2live requested review from a team May 27, 2021 18:43
@SimonBrandner SimonBrandner mentioned this pull request Jun 1, 2021
Merged
jryans
jryans approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise, thanks!
@dbkr dbkr requested review from gaelledel and removed request for a team June 4, 2021 10:07
@ajayyy
Copy link

ajayyy commented Jun 15, 2021

Would this just silence it for this call, or permanently? I think #15591 is about permanent silencing
@SimonBrandner
Copy link
Contributor Author

SimonBrandner commented Jun 16, 2021

Would this just silence it for this call, or permanently? I think #15591 is about permanent silencing

You're right, sorry. I'll look into that issue separately
gaelledel
gaelledel suggested changes Jun 17, 2021
View reviewed changes
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to see it in action? And see the light theme?
@germain-gg
Copy link
Contributor

germain-gg commented Jun 17, 2021

Is it possible to see it in action? And see the light theme?

@gaelledel you can see it in action through the Netlify deploy preview, https://deploy-preview-6082--matrix-react-sdk.netlify.app/
If you want to find the link next time you can scroll down at the bottom of the pull request and click on "details" next to netlify/matrix-react-sdk/deploy-preview
gaelledel
gaelledel approved these changes Jun 17, 2021
View reviewed changes
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Simon
@germain-gg germain-gg merged commit 71ff524 into matrix-org:develop Jun 17, 2021
@SimonBrandner SimonBrandner deleted the fix/mute-incoming-call/15591 branch June 17, 2021 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants

@SimonBrandner @ajayyy @germain-gg @jryans @gaelledel