Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 5, 2021

Fixes element-hq/element-web#17153
Should fix element-hq/element-web#17163

Review requested from Travis as he has highest chance of spotting any gotchas with this

@t3chguy t3chguy requested a review from turt2live May 5, 2021 15:02
@t3chguy t3chguy marked this pull request as ready for review May 5, 2021 15:02
@robintown
Copy link
Member

This is working much better for me :)

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks largely safe. The async signature on addFilter is a bit unfortunate from a puritan perspective, but not anything to argue against.

@t3chguy t3chguy merged commit 202dfd4 into develop May 5, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17153 branch May 5, 2021 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants