This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Switch the Home Space out for an All rooms space #5969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
t3chguy force-pushed the t3chguy/fix/17044.1 branch from 36062ba to 0c6da93 Compare t3chguy added the Z-Experiment 
t3chguy force-pushed the t3chguy/fix/17044.1 branch from 0c6da93 to a70be45 Compare … t3chguy/fix/17044.1 � Conflicts: � src/stores/room-list/RoomListStore.ts
t3chguy changed the title t3chguy removed the Z-Experiment 
niquewoodhouse approved these changes May 7, 2021
There was a problem hiding this comment.
I think this works as product intended:
- Home view
- All rooms are visible
- Searching in home searches all rooms, when you pick a room it doesn't redirect to the space because the room exists in Home
- Space view
- Space rooms visible
- Searching lets you search across all spaces, when you pick a room you are redirected to that space (not Home).
I look forward to collecting feedback on this.
| Might be worth asking @matrix-org/product to also review to check it works as intended. |
jryans approved these changes May 7, 2021
nadonomy approved these changes May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17196