This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Render ignored users setting regardless of if there are any #5860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I knew I'd forgotten something! 🙂 I've rebased with commit sign-off. First time I've used that Git feature! |
turt2live suggested changes Apr 13, 2021
| const userIds = ignoredUserIds | ||
| .map((u) => <IgnoredUser | ||
| const userIds = !ignoredUserIds?.length | ||
| ? 'You have no ignored users.' |
There was a problem hiding this comment.
This needs to be a translated string (_t and yarn i18n)
There was a problem hiding this comment.
Made the change. I've amended the commit as it's still a very small diff.
|
|
Signed-off-by: Sam A. Horvath-Hunt <hello@samhh.com>
turt2live approved these changes Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#14968.