Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 8, 2021

This is primarily intended for alternative setup UI or where the customisations end up configuring encryption some other way. If used without respecting the warnings in the docs, the user could end up at a blank page - use with caution, and only as directed.

Reviewer: If you need an example of this, please ping me somewhere.

This is primarily intended for alternative setup UI or where the customisations end up configuring encryption some other way. If used without respecting the warnings in the docs, the user could end up at a blank page - use with caution, and only as directed.
@turt2live turt2live requested a review from a team April 8, 2021 01:22
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something... but at the moment, this feels like a strange contortion of the CompleteSecurity component. Could we instead tweak postLoginSetup in MatrixChat to just skip the CompleteSecurity step and jump to the final logged in state...?

@turt2live turt2live requested a review from jryans April 8, 2021 15:29
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 😄

@turt2live turt2live merged commit 8aa4b1a into develop Apr 9, 2021
@turt2live turt2live deleted the travis/sponsored/security-disable-ui branch April 9, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants