This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Show waveform and timer in voice messages #5801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
turt2live commented Mar 25, 2021
| * displayed, making it possible to see "82:29". | ||
| */ | ||
| @replaceableComponent("views.voice_messages.Clock") | ||
| export default class Clock extends React.PureComponent<IProps, IState> { |
There was a problem hiding this comment.
just to try and explain why there's this, a LiveRecordingClock, and similar components for waveforms: the base components (not-LiveRecording ones) are eventually going to be used in the timeline to show voice messages. Just trying to figure out a component structure which keeps concerns isolated.
This is also me experimenting with component definitions, and still not being happy with the divide presented in this PR.
A bit annoying that it is async, but it'll do.
This reverts commit 5c685dc.
| I've reverted the AudioWorklet stuff because it horribly breaks the tests due to the compiler not understanding what scope it's being called at. I'll look at this in a future PR: element-hq/element-web#16819 |
dbkr reviewed Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#1358
Visuals:
Me talking:
WaveformTest-edited.mp4