This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix read receipts? #5567
Merged
Fix read receipts? #5567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live approved these changes Feb 23, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live approved these changes Feb 23, 2021
| right, let's try this :D |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This should hopefully fix #4377.
The thing is I am not certain... There has already been a PR which has attempted to do the same thing. After that PR was merged an issue saying the RR is below the "Today" indicator appeared. Due to this, the PR was reverted. The issue was later closed - attempts at reproducing it were unsuccessful.
So I decided to try to solve this myself. The thing is I ended up with a very similar code to the previous PR. I've attempted to reproduce the issue that caused the reversion unsuccessfully. That makes me think the issue might have been somewhere else and was fixed.
I've attempted to reproduce this in Matrix HQ and in my own testing room but everything seems fine.
I can definitely put this to more tests if someone gave me directions on what to focus