This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fixed Avatar for 3PID invites #5442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Definite has a few style nits where it does not look like the code around it, instead of having a huge if/else for the whole <MemberAvatar, maybe just have it set a variable |
t3chguy reviewed Nov 24, 2020
t3chguy reviewed Nov 25, 2020
| viewUserOnClick={true} | ||
| /> | ||
| </div> | ||
| ); |
t3chguy reviewed Nov 25, 2020
t3chguy reviewed Nov 25, 2020
| Thanks for reviewing @t3chguy. I've commited the suggestions you left. Please do let me know if some other changes are to be made. |
| Can confirm this works
|
t3chguy reviewed Nov 26, 2020
Comment on lines 749 to 750
| // set member to receiver (target) if it is a 3PID invite | ||
| // so that the correct avatar is shown |
There was a problem hiding this comment.
Suggested change
| // set member to receiver (target) if it is a 3PID invite | |
| // so that the correct avatar is shown | |
| // set member to receiver (target) if it is a 3PID invite | |
| // so that the correct avatar is shown as the text is | |
| // `$target accepted the invitation for $email` |
| Thanks for your contribution!! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#1568
I've added code to conditionally change the avatar which is shown. Please let me know if any changes are to be made. Much thanks.
Signed-off-by: Arsh Sharma arshsharma461@gmail.com