Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Apr 9, 2020

If this failed we assumed it didn't exist which would erroneously
prompt people to upgrade encryption.

If this failed we assumed it didn't exist which would erroneously prompt people to upgrade encryption.
@dbkr dbkr requested a review from a team April 9, 2020 12:42
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On some servers (like Ruma, Dendrite, etc.) this might infinite loop... Could we try up to some N times perhaps...?

I'll leave it up to you. 😄

@dbkr
Copy link
Member Author

dbkr commented Apr 9, 2020

Mmm - problem is we still don't really know what to do if it fails. One option would be to proceed as if encryption isn't available as above and just log the user in. I think probably best thing is to do this for now.

@dbkr dbkr merged commit 928d4ac into develop Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants