Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

foldleft
Copy link
Contributor

@foldleft foldleft commented Apr 3, 2020

@foldleft foldleft requested a review from a team April 3, 2020 10:49
@bwindels bwindels requested review from bwindels and removed request for a team April 6, 2020 08:24
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just 1 nit.

this.phase = PHASE_FINISHED;
this.emit("update");
// async - ask other clients for keys, if necessary
MatrixClientPeg.get()._crypto.cancelAndResendAllOutgoingKeyRequests();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding this method to the list of re-exported methods from crypto in client.js to avoid accessing _crypto here.

@foldleft foldleft merged commit 0e1341c into develop Apr 6, 2020
@foldleft foldleft deleted the foldleft/12843-resend-requests branch April 6, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants