This repository was archived by the owner on Sep 11, 2024. It is now read-only.
QR code reciprocation #4334
Merged
QR code reciprocation #4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bwindels force-pushed the bwindels/qr-reciprocate branch from d6f5eb7 to 31ca52d Compare 
| Actually polished the self-verification screen a bit more as part of this PR. |
foldleft approved these changes Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#1297
Fixes element-hq/element-web#12201
This moves the QR code generation into the js-sdk, see the linked PR why.
Self-verification (the UX will need to be cleaned up here, leaving that as part of element-hq/element-web#12725):
User-verification: