This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use componentDidMount in place of componentWillMount where possible #4313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes a common React warning we see. Most of these components should be using constructors instead, however componentDidMount is just as good (and doesn't require converting most of these). Conversion to classes will be done in a later stage of React warning fixes. For element-hq/element-web#12877
turt2live force-pushed the travis/react-warnings/1-componentDidMount branch from 6053926 to 3f99332 Compare 
t3chguy reviewed Apr 1, 2020
t3chguy reviewed Apr 1, 2020
t3chguy approved these changes Apr 1, 2020
turt2live added a commit that referenced this pull request Apr 1, 2020
Fixes element-hq/element-web#12990 Regressed in #4313
dbkr added a commit that referenced this pull request Apr 2, 2020
Broken in #4313 Fixes element-hq/element-web#13001
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes a common React warning we see. Most of these components should be using constructors instead, however componentDidMount is just as good (and doesn't require converting most of these).
Conversion to classes will be done in a later stage of React warning fixes.
For element-hq/element-web#12877