Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team March 28, 2020 00:52
@bwindels
Copy link
Contributor

actually, need to double check but we might be able to get rid of the autohidescrollbar component completely as it doesn't require js anymore, or does it?

@bwindels
Copy link
Contributor

bwindels commented Mar 30, 2020

Thanks for taking a look at this btw. So yeah, we could apply the behaviour to any scrolling area by applying the css class (mx_AutoHideScrollbar). I wonder if we should rename it for that purpose though?

@t3chguy
Copy link
Member Author

t3chguy commented Mar 30, 2020

Yeah, we could apply the behaviour to any scrolling area by applying the css class (mx_AutoHideScrollbar). I wonder if we should rename it for that purpose though?

Yes but I think maybe we should just apply it globally to all scrollbars, very few scrollbars are always-visible and where they are it seems inconsistent.
image

@bwindels
Copy link
Contributor

So, as discussed in the standup, we keep the component to isolate the css class. So we just merge this and then I have a look why code blocks reverted to ugly scrollbars?

@t3chguy
Copy link
Member Author

t3chguy commented Mar 30, 2020

sgtm

Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, forgot to approve.

@t3chguy t3chguy merged commit 5375f88 into develop Mar 30, 2020
@t3chguy t3chguy deleted the t3chguy/fix_scrollbars branch April 27, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants