This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Migrate SSSS to symmetric #4224
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-js-sdk#1238
Scenarios:
For migrating existing key backup, no SSSS, react-sdk needs to pass the backup recovery key to js-sdk somehow. This would be done in the the
_bootstrapSecretStorage
function ofCreateSecretStorageDialog.js
. This would either be done by prompting the user and then passing the key to js-sdk'sbootstrapSecretStorage
(ifCreateSecretStorageDialog
knows when it needs to prompt for the recovery key), or by passing a callback to js-sdk'sbootstrapSecretStorage
, which will be called whenbootstrapSecretStorage
needs the key. js-sdk currently hardcodes a random key at https://github.com/matrix-org/matrix-js-sdk/pull/1238/files#diff-fa4472db829c5a59596c29a2f43e8f9cR506 .