This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Make Mjolnir stop more robust #4186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since Mjolnir is a shared instance, we need to be a bit more careful about clearing internal state than we do for components. This clears watcher and dispatcher refs in case `stop` is called multiple times (which can happen in prod as well as tests).
turt2live reviewed Mar 9, 2020
Comment on lines -74 to -75
| // Only the tests cause problems with this particular block of code. We should | ||
| // never be here in production. |
There was a problem hiding this comment.
These two lines are the reason your tests are failing, I'll bet.
| Looks like no change was needed, just intermittent tests being flaky. |
turt2live approved these changes Mar 9, 2020
| Hmm, well, your commit message from back was suspecting that |
| oh, then this is fine. I thought the try catch was for something else... |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since Mjolnir is a shared instance, we need to be a bit more careful about
clearing internal state than we do for components. This clears watcher and
dispatcher refs in case
stopis called multiple times (which can happen inprod as well as tests).