This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fall back to to_device verification if other user hasn't uploaded cross-signing keys #4181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…sender yet, makes e2e tests fail
…cyverififnoxsignkeys
bwindels changed the title 
turt2live approved these changes Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Requires #4180
Fixes element-hq/element-web#12617
Actual changes are in 1f9bd55
This will send it with a .request event, and to all the devices known for that user. The other party can then accept the request on any of those devices and do the verification between those 2 devices. There is a separate story to verify a specific device (they only thing riot used to expose in its UI) at element-hq/element-web#12636 where we will send a .start with a given method straight away.