Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 23, 2019

This is against travis/sourcemaps for safety.

Split from #3744

It is best to review this commit-by-commit.


This PR and others in the series have their overview covered here: https://gist.github.com/turt2live/a3fc7c9712b8ef0f1f758611aa33382d

@turt2live turt2live requested a review from a team December 23, 2019 04:36
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your cosmetic changes aren't, in that you are removing git-revision.txt and docs from the npm package and you're turning off source maps, both of which seem odd?

@turt2live
Copy link
Member Author

the -s was redundant - sourcemaps are still a thing. git-revision.txt was just moved elsewhere in the list (slight reorganization), though docs going missing is a bug.

@dbkr
Copy link
Member

dbkr commented Jan 8, 2020

Ah, not sure how I missed git-revision.txt. Presumably the source maps thing is specifically from the fact that babelrc.js now has a source maps option?

@turt2live
Copy link
Member Author

That's the theory, and a believable one.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winner then 👍

@turt2live turt2live merged commit 85c4c72 into travis/sourcemaps Jan 8, 2020
@turt2live turt2live deleted the travis/babel7-wp-package branch January 8, 2020 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants