This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Convert CommonJS exports to ES6 exports #3761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We use `export default` begrudgingly here. Ideally we'd use just `export`, though this entire SDK expects things to be exported as a default. Instead of breaking everything, we'll sacrifice our export pattern for a smaller diff - a later commit can always do the default export -> regular export conversion.
| A failing build is not surprising - this will be fixed in a future PR before the feature branch goes to develop. |
This was referenced Dec 23, 2019
dbkr reviewed Dec 27, 2019
| 'use strict'; | ||
| | ||
| module.exports = function(dest, src) { | ||
| export default function(dest, src) { |
There was a problem hiding this comment.
I thought export default broke things?
There was a problem hiding this comment.
It does for the js-sdk, not for the react-sdk. We don't have a central index for the react-sdk that we need to worry about
| import {PushRuleVectorState} from "./PushRuleVectorState"; | ||
| | ||
| module.exports = { | ||
| export class ContentRules { |
There was a problem hiding this comment.
Same comment as matrix-org/matrix-js-sdk#1134 on classes of static methods.
| 'use strict'; | ||
| | ||
| module.exports = { | ||
| export class NotificationUtils { |
dbkr approved these changes Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is against
travis/sourcemapsfor safety.Split from #3744
Part 1 of a few for ES6 conversion. Best reviewed commit-by-commit.
This PR and others in the series have their overview covered here: https://gist.github.com/turt2live/a3fc7c9712b8ef0f1f758611aa33382d