This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix room list filtering weird case sensitivity #3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live approved these changes Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11701
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com
unhomoglyph converts funky unicode characters to their non-confusable counterparts as per http://www.unicode.org/Public/security/latest/confusables.txt
the issue was we converted the output of it to lower case but its input was mixed case, which causes fun cases like
e.g
m->rn, (r, n) butM->Mwhich means we should lowerCase its input, but we must also lowerCase its output because of mappings like𝐊->K(which would not matchkotherwise)