This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add an option to invite users to upgraded private rooms #3684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The option doesn't show up on public room upgrades.
| What changed from 6 days ago? element-hq/element-web#11464 (comment) |
turt2live commented Nov 28, 2019
| return; | ||
| } | ||
| | ||
| console.error(err); |
There was a problem hiding this comment.
rationale: developers saying "why is my invite failing"
| @aaronraimist nothing. This isn't my favourite fix at all because ideally we'd just transfer membership instead of hammering the server, but here we are. |
bwindels approved these changes Nov 28, 2019
bwindels approved these changes Nov 28, 2019
|
@turt2live following on from our chat outside of GitHub: Updated design, making note to trigger the normal help modal, and implement the toggle interaction on the right for consistency with the rest of the app (ref create room). Copy for your clipboard: |
| per conversation out of band, to make it a bit fairer to Bruno I'm going to merge this as-is and put the design through a subsequent PR right away. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The option doesn't show up on public room upgrades. We abuse the MultiInviter for this so we don't have to deal with failure.
This only adds the toggle switch to this dialog:
