Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add a link to the labs feature documentation #3675

Merged
merged 3 commits into from
Nov 29, 2019
Merged

Add a link to the labs feature documentation #3675

merged 3 commits into from
Nov 29, 2019

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Nov 26, 2019 •
edited
Loading

@aaronraimist
Add a link to the labs feature documentation
7905e6c 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
turt2live
turt2live approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - submitting for design review
@turt2live turt2live requested a review from nadonomy November 26, 2019 20:53
@aaronraimist
Fix indentation
98c4726 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@turt2live
Copy link
Member

Blocking this on design review, or product if sufficient.
nadonomy
nadonomy suggested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference— in the long term we definitely shouldn't be linking to documentation on GitHub expecting it to be a reasonable place for users (rather than developers) to consume docs. However, we already do this throughout the app so no reason to block this PR on that.

Can we simplify the copy & make the tone of voice less passive? To:

Customise your experience with experimental labs features. Learn more
@turt2live turt2live removed the blocked label Nov 28, 2019
@aaronraimist
Improve wording
4c50ac0 
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Contributor Author

Updated to use your wording. I don't think there are actually that many places in the app that link to GitHub for documentation but I think it is appropriate here because the whole point of adding this sentence is to clarify that labs features aren't meant for the average user.

Screen Shot 2019-11-28 at 10 23 01 PM
@turt2live turt2live merged commit 5aad914 into matrix-org:develop Nov 29, 2019
@aaronraimist aaronraimist deleted the labs-explain branch November 29, 2019 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@aaronraimist @turt2live @nadonomy