This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove getBaseTheme #3638
Merged
Remove getBaseTheme #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uses CSS `prefers-color-scheme` to get the user's preferred colour scheme. Also bundles up some theme logic into its own class.
This was only used by vector/index.js, in the code removed by element-hq/element-web#11445 React SDK does a very similar thing in setTheme but also gets the rest of the custom theme name. Requires element-hq/element-web#11445
bwindels approved these changes Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was only used by vector/index.js, in the code removed by
element-hq/element-web#11445
React SDK does a very similar thing in setTheme but also gets the
rest of the custom theme name.
Requires element-hq/element-web#11445