Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

bwindels
Copy link
Contributor

Fixes element-hq/element-web#11422

Should ideally be styleable with CSS for theming, but rather do this quick fix right now. Looks ok in light and dark (albeit somewhat low contrast) theme.

image

@bwindels bwindels requested a review from a team November 19, 2019 13:44
@bwindels bwindels force-pushed the bwindels/fix-roomstatus-e2e-icon branch from c09992b to de02872 Compare November 19, 2019 14:06
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhere we preload this image too because it's possible that it can fail to load.

@jryans
Copy link
Collaborator

jryans commented Nov 19, 2019

somewhere we preload this image too because it's possible that it can fail to load.

Yes, that happens in riot-web's index.html.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side lgtm, but will need a riot-web PR per comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants