This repository was archived by the owner on Sep 11, 2024. It is now read-only.
New design for member panel #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make it a circle with the profile picture centered, with a max height/width of 30vh
While we don't have canonical DMs yet, it takes you to the most recently active DM room
also don't download devices as long as room is not encrypted
as they are only used for verification right now, and verification events will be unverified by definition, so no need to alarm users needlessly. Also, this breaks the bubble layout on hover due to e2e icons and verified left border style.
still saves when changing the selector though
as the powerlevel on the member is not yet updated at the time RoomState.events is emitted. Also listen on the client for this event as the currentState object can change when the timeline is reset.
one while editing (PowerLevelEditor) and one while not editing (PowerLevelSection). Also save when pressing the button, not when changing the power dropdown. Also show the spinner next to the dropdown when saving, not at the bottom of the component.
making whole room view grow taller than viewport
bwindels force-pushed the bwindels/userinfomakeover branch from 6f8ce37 to d416ba2 Compare 
dbkr approved these changes Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements element-hq/element-web#11222
Requires matrix-org/matrix-js-sdk#1072
Fixes element-hq/element-web#11338
All of this should be hidden behind the
feature_user_info_panelfeature flag. Shall I make the effort of renaming it to make it clear that this is also about the new design?As we don't show devices anymore when the room is not encrypted, I added a big "Verify" button in the security section to start the verification through the dialog (the screenshots were made before this button was added).
In general, the commits should be reviewable individually, apart from a few of the last ones that are not entirely in order. sorry about that.